Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UD] Add Temporary Storage toggle button to Get Started page #16016

Merged
merged 1 commit into from
Feb 14, 2020
Merged

[UD] Add Temporary Storage toggle button to Get Started page #16016

merged 1 commit into from
Feb 14, 2020

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR adds the toggle button for Temporary Storage on Get Started page.

Screenshot 2020-02-13 at 10 29 02

What issues does this PR fix or reference?

resolves #15855

Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com

@akurinnoy
[UD] Add Temporary Storage toggle to Get Started page
a0a265f 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy akurinnoy self-assigned this Feb 13, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

Can one of the admins verify this patch?

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Feb 13, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@SkorikSergey
Copy link
Contributor

[test]

@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

E2E tests of Eclipse Che Multiuser on OCP has been successful:

sleshchenko
sleshchenko approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Everything works as expected! 👍

@akurinnoy akurinnoy merged commit fdb3c2f into master Feb 14, 2020
@akurinnoy akurinnoy deleted the che-15855 branch February 14, 2020 09:43
@che-bot che-bot added this to the 7.9.0 milestone Feb 14, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko approved these changes

@olexii4 olexii4 olexii4 approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

@ashumilova ashumilova Awaiting requested review from ashumilova

@benoitf benoitf Awaiting requested review from benoitf

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@akurinnoy akurinnoy

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.9.0
Development

Successfully merging this pull request may close these issues.

Add Temporary Storage toggle button on Get Started page
5 participants
@akurinnoy @che-bot @SkorikSergey @sleshchenko @olexii4